update duckdb version #134
Conversation
|
|
|
Can you update to tip of duckdb instead of this version? |
I figured out that the errors are coming for filter type OPTIONAL_FILTER error: unsupported table filter type OPTIONAL_FILTER |
This is introduced a while back. The test as I understand, does a get_substrait(query) and use the plan. Since, get_substrait() is provided by duckdb, I am checking the changes around that area as well. |
Also, make sure filter type constant comparison always returns a boolean
srikrishnak
force-pushed
the
update-duckdb-version
branch
from
0a09ed2 to
95f42b3
Compare
| @@ -698,7 +698,7 @@ substrait::Expression *DuckDBToSubstrait::TransformConstantComparisonFilter(uint | |||
| auto s_expr = new substrait::Expression(); | |||
| auto s_scalar = s_expr->mutable_scalar_function(); | |||
| auto &constant_filter = dfilter.Cast<ConstantFilter>(); | |||
| *s_scalar->mutable_output_type() = DuckToSubstraitType(return_type); | |||
| *s_scalar->mutable_output_type() = DuckToSubstraitType(LogicalTypeId::BOOLEAN); | |||
There was a problem hiding this comment.
Could this theoretically return a different type for ConjunctionAndFilter and ConstantComparisonFilter since we'er using return_type below? If so, should we use replace the use of return_type as well (or only set this to boolean for optional_filter)?
There was a problem hiding this comment.
The return type for any of these comparison is always Boolean.
The return for other filters is not changed.
No description provided.