Bail to web-based Link when needed #4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 New dead code detected in this PR: PayWithLinkViewController-SignUpViewController.swift:244 warning: Parameter 'attestionError' is unused
PayWithLinkViewController-SignUpViewModel.swift:23 warning: Parameter 'attestionError' is unused
PayWithNativeLinkController.swift:126 warning: Parameter 'payWithLinkWebController' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
davidme-stripe
force-pushed
the
davidme/fix-concurrent-assertions
branch
from
3bb4621 to
7df4065
Compare
wooj-stripe
reviewed
Jan 7, 2025
...entSheet/StripePaymentSheet/Source/Internal/Link/Controllers/PayWithLinkViewController.swift
Show resolved
Hide resolved
...entSheet/StripePaymentSheet/Source/Internal/Link/Controllers/PayWithLinkViewController.swift
Outdated
Show resolved
Hide resolved
...mentSheet/StripePaymentSheet/Source/Internal/Link/Controllers/PayWithLinkWebController.swift
Outdated
Show resolved
Hide resolved
wooj-stripe
previously approved these changes
Jan 7, 2025
wooj-stripe
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for bailing back to the web Link flow when attestation fails. This makes launching Link more responsive for the expected case (that attestation will succeed if the app has attestation enabled and the device supports attestation), while allowing a graceful fallback in the unexpected case (the attestation or assertion fails). We'll bail if either:
Motivation
Handle unexpected errors in a more user-friendly way.
Testing
Tested manually by intentionally breaking assertion and attestation in both cases.
Added a test that uses mocks to fail attestation and check that the ASWebAuthenticationSession is presented.
Changelog
None