-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOBILESDK-2482] Apply appearance API typography to dialog buttons #9850
Conversation
Diffuse output:
APK
DEX
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add another test here for the crazy appearance?
val paparazziWithEveryAppearance = PaparazziRule( | ||
SystemAppearance.entries, | ||
listOf(FontSize.DefaultFont), | ||
listOf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can replace this with PaymentSheetAppearance.entries
@get:Rule | ||
val paparazziWithEveryAppearance = PaparazziRule( | ||
SystemAppearance.entries, | ||
listOf(FontSize.DefaultFont), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want all the font sizes too.
Summary
Apply appearance API typography to dialog buttons by assigning correct style.
Typography.body1
is used instead ofTypography.button
because the former utilizes the Appearance API, whereas the latter does not.Motivation
Buttons in remove saved PM dialog don't use appearance API typography
https://jira.corp.stripe.com/browse/MOBILESDK-2482
Testing
Screenshots