-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC] Adds attestation analytics events. #9831
base: carlosmuvi/12-25-adds-signup-mobile-endpoint
Are you sure you want to change the base?
[FC] Adds attestation analytics events. #9831
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Diffuse output:
APK
|
95103be
to
439af93
Compare
3536680
to
2cacb8a
Compare
439af93
to
c466db6
Compare
2cacb8a
to
d800d69
Compare
c466db6
to
8984961
Compare
d800d69
to
156f68a
Compare
8984961
to
5a1f7e4
Compare
156f68a
to
4e2309d
Compare
5a1f7e4
to
738d2c0
Compare
4e2309d
to
79a9026
Compare
import com.stripe.android.financialconnections.analytics.FinancialConnectionsAnalyticsTracker | ||
import com.stripe.attestation.IntegrityRequestManager | ||
|
||
internal class RequestIntegrityToken( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constructor needs the @Inject
annotation for Dagger dependency injection to work properly. Consider adding:
@Inject constructor(
private val integrityRequestManager: IntegrityRequestManager,
private val analyticsTracker: FinancialConnectionsAnalyticsTracker
)
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
738d2c0
to
4e61478
Compare
79a9026
to
839dba4
Compare
4e61478
to
230d44b
Compare
839dba4
to
b01fb4f
Compare
Summary
Added analytics events to track Play Integrity attestation initialization and token requests on lookup and signup mobile empoints.
Motivation
Testing