Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC] Adds attestation analytics events. #9831

Draft
wants to merge 1 commit into
base: carlosmuvi/12-25-adds-signup-mobile-endpoint
Choose a base branch
from

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented Dec 28, 2024

Summary

Added analytics events to track Play Integrity attestation initialization and token requests on lookup and signup mobile empoints.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

@carlosmuvi-stripe
Copy link
Collaborator Author

@carlosmuvi-stripe carlosmuvi-stripe changed the title Adds attestation analytics events. [FC] Adds attestation analytics events. Dec 28, 2024
Copy link
Contributor

github-actions bot commented Dec 28, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │   0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │   0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │   0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.3 KiB │ +13 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +13 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19969 │ 19969 │ 0 (+0 -0) 
   types │  6191 │  6191 │ 0 (+0 -0) 
 classes │  4982 │  4982 │ 0 (+0 -0) 
 methods │ 29769 │ 29769 │ 0 (+0 -0) 
  fields │ 17540 │ 17540 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
    compressed    │  uncompressed   │                                           
──────────┬───────┼──────────┬──────┤                                           
 size     │ diff  │ size     │ diff │ path                                      
──────────┼───────┼──────────┼──────┼───────────────────────────────────────────
 28.5 KiB │ +11 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    272 B │  +1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │  +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼───────┼──────────┼──────┼───────────────────────────────────────────
 29.9 KiB │ +13 B │ 64.2 KiB │  0 B │ (total)

@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-25-adds-signup-mobile-endpoint branch from 95103be to 439af93 Compare December 28, 2024 16:27
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-28-adds_attestation_analytics_events branch from 3536680 to 2cacb8a Compare December 28, 2024 16:27
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-25-adds-signup-mobile-endpoint branch from 439af93 to c466db6 Compare December 28, 2024 16:30
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-28-adds_attestation_analytics_events branch from 2cacb8a to d800d69 Compare December 28, 2024 16:30
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-25-adds-signup-mobile-endpoint branch from c466db6 to 8984961 Compare December 30, 2024 09:48
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-28-adds_attestation_analytics_events branch from d800d69 to 156f68a Compare December 30, 2024 09:48
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-25-adds-signup-mobile-endpoint branch from 8984961 to 5a1f7e4 Compare January 2, 2025 15:55
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-28-adds_attestation_analytics_events branch from 156f68a to 4e2309d Compare January 2, 2025 15:55
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-25-adds-signup-mobile-endpoint branch from 5a1f7e4 to 738d2c0 Compare January 2, 2025 16:00
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-28-adds_attestation_analytics_events branch from 4e2309d to 79a9026 Compare January 2, 2025 16:00
import com.stripe.android.financialconnections.analytics.FinancialConnectionsAnalyticsTracker
import com.stripe.attestation.IntegrityRequestManager

internal class RequestIntegrityToken(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constructor needs the @Inject annotation for Dagger dependency injection to work properly. Consider adding:

@Inject constructor(
    private val integrityRequestManager: IntegrityRequestManager,
    private val analyticsTracker: FinancialConnectionsAnalyticsTracker
)

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-25-adds-signup-mobile-endpoint branch from 738d2c0 to 4e61478 Compare January 2, 2025 18:09
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-28-adds_attestation_analytics_events branch from 79a9026 to 839dba4 Compare January 2, 2025 18:09
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-25-adds-signup-mobile-endpoint branch from 4e61478 to 230d44b Compare January 2, 2025 18:11
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-28-adds_attestation_analytics_events branch from 839dba4 to b01fb4f Compare January 2, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant