-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOBILESDK-2681] [MOBILESDK-2682] Default Payment Method Label #9824
Conversation
Update DefaultPaymentMethodLabel.kt
Diffuse output:
APK
DEX
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new label UI here LGTM!
Can we update this PR to just make one conceptual change? In this case, I think that should be adding the new payment method label.
The new feature flag and one usage of it is kind of orthogonal to the creation of the new label (since the label isn't being used yet), so I don't think those changes belong in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this test -- this doesn't seem to be testing anything custom about our code. We can use UI tests in later PRs to verify that the label is shown when we expect (in the actual horizontal and vertical UIs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In another comment, I suggested that we move this code to another PR, so this shouldn't affect this PR, but for the future -- I think we should read the feature flag outside of the JSON parser. Currently, this parser is only responsible for parsing, not for any logic. We should determine whether we want to read the defaultPaymentMethod
value elsewhere in the code, not directly within the parser
Summary
Added feature flag for default payment method
Added Default Payment Method Label
This will be added to
SavedPaymentMethodTab
PaymentMethodRowButton.RowInnerContent
to show is a payment method is default
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2681
https://jira.corp.stripe.com/browse/MOBILESDK-2682
Testing
Screenshots
Changelog
N.A.