Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to kotlin 2.0.20. #9512

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Update to kotlin 2.0.20. #9512

merged 3 commits into from
Oct 25, 2024

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Oct 24, 2024

Summary

Updates kotlin to 2.0.20!

Motivation

Next major version + keeping dependencies up to date.

Copy link
Contributor

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

@jaynewstrom-stripe jaynewstrom-stripe added the accept-risky-change accept-risky-change label Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed             │          uncompressed           
          ├───────────┬───────────┬───────────┼─────────┬───────────┬───────────
 APK      │ old       │ new       │ diff      │ old     │ new       │ diff      
──────────┼───────────┼───────────┼───────────┼─────────┼───────────┼───────────
      dex │     4 MiB │     4 MiB │ +35.9 KiB │ 8.7 MiB │   8.8 MiB │ +61.6 KiB 
     arsc │   2.3 MiB │   2.3 MiB │       0 B │ 2.3 MiB │   2.3 MiB │       0 B 
 manifest │     5 KiB │     5 KiB │       0 B │  25 KiB │    25 KiB │       0 B 
      res │ 932.6 KiB │ 932.6 KiB │       0 B │ 1.5 MiB │   1.5 MiB │       0 B 
   native │   2.6 MiB │   2.6 MiB │       0 B │   6 MiB │     6 MiB │       0 B 
    asset │   2.9 MiB │   2.9 MiB │  -1.9 KiB │ 2.9 MiB │   2.9 MiB │  -1.9 KiB 
    other │ 201.2 KiB │ 201.1 KiB │     -11 B │ 443 KiB │ 443.1 KiB │     +11 B 
──────────┼───────────┼───────────┼───────────┼─────────┼───────────┼───────────
    total │    13 MiB │    13 MiB │ +33.9 KiB │  22 MiB │    22 MiB │ +59.7 KiB 

 DEX     │ old   │ new   │ diff                
─────────┼───────┼───────┼─────────────────────
   files │     1 │     1 │   0                 
 strings │ 42085 │ 42160 │ +75 (+876 -801)     
   types │ 14321 │ 14328 │  +7 (+743 -736)     
 classes │ 11932 │ 11940 │  +8 (+479 -471)     
 methods │ 61585 │ 61584 │  -1 (+18785 -18786) 
  fields │ 40315 │ 40414 │ +99 (+14470 -14371) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6271 │ 6271 │  0
APK
      compressed      │     uncompressed      │                                           
──────────┬───────────┼───────────┬───────────┤                                           
 size     │ diff      │ size      │ diff      │ path                                      
──────────┼───────────┼───────────┼───────────┼───────────────────────────────────────────
    4 MiB │ +35.9 KiB │   8.8 MiB │ +61.6 KiB │ ∆ classes.dex                             
  6.7 KiB │  -1.9 KiB │   6.5 KiB │  -1.9 KiB │ ∆ assets/dexopt/baseline.prof             
    127 B │    +127 B │       5 B │      +5 B │ + META-INF/services/T9.v                  
    127 B │    +127 B │       5 B │      +5 B │ + META-INF/services/U9.a                  
          │    -127 B │           │      -5 B │ - META-INF/services/S9.y                  
          │    -127 B │           │      -5 B │ - META-INF/services/T9.a                  
    1 KiB │     -81 B │     914 B │     -81 B │ ∆ assets/dexopt/baseline.profm            
 53.6 KiB │      -6 B │   119 KiB │       0 B │ ∆ META-INF/CERT.SF                        
    887 B │      -5 B │   1.7 KiB │     -10 B │ ∆ DebugProbesKt.bin                       
  5.3 KiB │      +5 B │  18.2 KiB │     +21 B │ ∆ kotlin/kotlin.kotlin_builtins           
    268 B │      -3 B │     120 B │       0 B │ ∆ META-INF/version-control-info.textproto 
 50.4 KiB │      -3 B │ 118.9 KiB │       0 B │ ∆ META-INF/MANIFEST.MF                    
    416 B │      +1 B │     627 B │       0 B │ ∆ kotlin-tooling-metadata.json            
──────────┼───────────┼───────────┼───────────┼───────────────────────────────────────────
  4.1 MiB │ +33.9 KiB │     9 MiB │ +59.7 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff            
  ───────┼───────┼─────────────────
   42085 │ 42160 │ +75 (+876 -801) 
  
  +         
  +     )
  +     ),
  +     number = NumberHexFormat(
  +  > endIndex: 
  +  as the serialized body of boolean at element: 
  +  as the serialized body of byte at element: 
  +  as the serialized body of char at element: 
  +  as the serialized body of double at element: 
  +  as the serialized body of float at element: 
  +  as the serialized body of int at element: 
  +  as the serialized body of long at element: 
  +  as the serialized body of short at element: 
  +  as the serialized body of string at element: 
  +  at element: 
  +  cannot be serialized polymorphically because it is represented as 
  +  there already exists 
  +  value at element: 
  + " of length 
  + ",
  + _.
  + _this_Destination
  + _this_KeyboardActions
  + ' as 
  + ' should be quoted at element: 
  + ', got null literal instead at element: 
  + '.
  The result won't fit the type being parsed.
  + ,
      bytes = BytesHexFormat(
  
  + , allowComments=
  + , but was "
  + , but was '
  + , endIndex: 
  + .
                  Please refer to SerialDescriptor documentation for additional information.
            
  + .
  Use 'isLenient = true' in 'Json {}' builder to accept non-compliant JSON.
  + . Make sure that its JsonTransformingSerializer returns JsonObject, so class discriminator can be added to it.
  + .limitedParallelism(
  + <destruct>
  + <unused var>
  + BytesHexFormat(
  
  + Class with serial name 
  + DefaultExecutor
  + Expected '-' (hyphen) at index 8, but was 
  + Expected a 36-char string in the standard uuid format.
  + Expected a hexadecimal digit at index 
  + Expected a hexadecimal number with prefix "" and suffix "", but was 
  + Expected at least 1 hexadecimal digits at index 
  + Expected end of the block comment: "*/", but had EOF instead
  + Expected string value for a non-null key '
  + Expected the hexadecimal digit '0' at index 
  + FILZ
  + Failed to parse literal '
  + HexFormat(
      upperCase = 
  + JIIL
  + Kotlin reflection is not yet supported for synthetic Java properties. Please follow/upvote https://youtrack.jetbrains.com/issue/KT-55980
  + LA5/b;
  + LB6/F;
  + LB6/G;
  + LB6/H;
  + LB6/I;
  + LC6/K;
  + LC6/L;
  + LC6/M;
  + LC6/N;
  + LD7/g0;
  + LD7/h0;
  + LD7/i0;
  + LD7/j0;
  + LD7/k0;
  + LD7/l0;
  + LD7/m0;
  + LE0/h;
  + LE7/v;
  + LE7/w;
  + LE7/x;
  + LE7/y;
  + LF0/o;
  + LF8/e;
  + LFa/a;
  + LFa/b;
  + LFa/c;
  + LG0/M;
  + LG6/d0;
  + LH1/G;
  + LHa/n;
  + LIa/g;
  + LIa/h;
  + LIa/i;
  + LIa/j;
  + LIa/k;
  + LIa/l;
  + LIa/m;
  + LJa/c;
  + LJa/d;
  + LJa/e;
  + LJa/f;
  + LLa/b;
  + LMa/a;
  + LN3/i;
  + LO3/a;
  + LQ2/A;
  + LQ7/m;
  + LQ7/n;
  + LQ7/o;
  + LQ9/w;
  + LQ9/x;
  + LQ9/y;
  + LQ9/z;
  + LQa/b;
  + LQa/c;
  + LQa/d;
  + LQa/e;
  + LQa/f;
  + LQa/g;
  + LQa/h;
  + LQa/i;
  + LQa/j;
  + LQa/k;
  + LQa/l;
  + LQa/m;
  + LQa/n;
  + LQa/o;
  + LQa/p;
  + LQa/q;
  + LQa/r;
  + LQa/s;
  + LQa/t;
  + LQa/u;
  + LQa/v;
  + LQa/w;
  + LQa/x;
  + LT9/A0;
  + LT9/A;
  + LT9/B0;
  + LT9/B;
  + LT9/C;
  + LT9/D;
  + LT9/E;
  + LT9/F;
  + LT9/G;
  + LT9/H;
  + LT9/I;
  + LT9/J;
  + LT9/K;
  + LT9/L;
  + LT9/M;
  + LT9/N;
  + LT9/O;
  + LT9/P;
  + LT9/Q;
  + LT9/S;
  + LT9/T;
  + LT9/U;
  + LT9/V;
  + LT9/W;
  + LT9/X;
  + LT9/Y;
  + LT9/Z;
  + LT9/a0;
  + LT9/b0;
  + LT9/c0;
  + LT9/d0;
  + LT9/e0;
  + LT9/f0;
  + LT9/f;
  + LT9/g0;
  + LT9/g;
  + LT9/h0;
  + LT9/h;
  + LT9/i0;
  + LT9/i;
  + LT9/j0;
  + LT9/j;
  + LT9/k0;
  + LT9/k;
  + LT9/l0;
  + LT9/l;
  + LT9/m0;
  + LT9/m;
  + LT9/n0;
  + LT9/n;
  + LT9/o0;
  + LT9/o;
  + LT9/p0;
  + LT9/p;
  + LT9/q0;
  + LT9/q;
  + LT9/r0;
  + LT9/r;
  + LT9/s0;
  + LT9/s;
  + LT9/t0;
  + LT9/t;
  + LT9/u0;
  + LT9/u;
  + LT9/v0;
  + LT9/v;
  + LT9/w0;
  + LT9/w;
  + LT9/x0;
  + LT9/x;
  + LT9/y0;
  + LT9/y;
  + LT9/z0;
  + LT9/z;
  + LTa/c;
  + LTa/d;
  + LU7/L;
  + LW9/H;
  + LW9/I;
  + LW9/J;
  + LW9/K;
  + LW9/L;
  + LW9/M;
  + LW9/N;
  + LW9/O;
  + LW9/P;
  + LW9/Q;
  + LW9/S;
  + LW9/T;
  + LW9/U;
  + LW9/V;
  + LW9/W;
  + LW9/X;
  + LW9/Y;
  + LW9/Z;
  + LW9/a0;
  + LW9/b0;
  + LW9/c0;
  + LW9/d0;
  + LW9/e0;
  + LW9/f0;
  + LW9/g0;
  + LW9/h0;
  + LX2/q;
  + LX7/I;
  + LX7/J;
  + LX9/A;
  + LX9/B;
  + LX9/C;
  + LX9/D;
  + LX9/E;
  + LX9/F;
  + LX9/z;
  + LY/W;
  + LY/X;
  + LY/Y;
  + LY/Z;
  + LY/a0;
  + LY9/a;
  + LY9/b;
  + LY9/c;
  + LY9/d;
  + LY9/e;
  + LY9/f;
  + LY9/g;
  + LY9/h;
  + LY9/i;
  
...✂

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/kotlin2 branch 3 times, most recently from c28e2c2 to f329afe Compare October 25, 2024 16:54
Copy link
Contributor

@lng-stripe lng-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@jaynewstrom-stripe jaynewstrom-stripe merged commit 44a5dc7 into master Oct 25, 2024
18 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/kotlin2 branch October 25, 2024 20:56
toluo-stripe pushed a commit that referenced this pull request Oct 29, 2024
* Update to kotlin 2.0.20.

* Update dependency baselines.

* Update api baselines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accept-risky-change accept-risky-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants