Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update dependencies #23

wants to merge 2 commits into from

Conversation

montdidier
Copy link

@montdidier montdidier commented Aug 16, 2017 •
edited
Loading

Addresses #18

OutlawAndy
OutlawAndy requested changes Aug 17, 2017
View reviewed changes
Copy link
Member

@OutlawAndy OutlawAndy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request, looks great!
If you would please address the 2 inline comments I left, I'll get it merged.

lib/stripe/cli/command.rb Outdated Show resolved Hide resolved
lib/stripe/cli.rb Outdated Show resolved Hide resolved
@montdidier
Copy link
Author

Sorry for the long absence. Changed as requested.

@montdidier montdidier changed the title update dependencies Update dependencies Dec 6, 2017
@montdidier
Copy link
Author

@OutlawAndy bump. Anything else you need for this?

@cleric0211
Copy link

Nice goodjob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OutlawAndy OutlawAndy OutlawAndy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@montdidier @cleric0211 @OutlawAndy