Skip to content

Commit

Permalink
Merge pull request #608 from streamich/log-types
Browse files Browse the repository at this point in the history
JSON CRDT `Log` inner typing support
  • Loading branch information
streamich authored Apr 29, 2024
2 parents dbdb619 + 6ae8b30 commit 9aa5923
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 11 deletions.
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/CHANGELOG*
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@
"lib/"
],
"scripts": {
"prettier": "npx [email protected] --ignore-path .gitignore --write .",
"prettier:check": "npx [email protected] --ignore-path .gitignore --check .",
"prettier": "npx [email protected] --write .",
"prettier:check": "npx [email protected] --check .",
"lint": "yarn tslint",
"lint:fix": "yarn tslint --fix",
"tslint": "tslint 'src/**/*.{js,jsx,ts,tsx}' -t verbose --project .",
Expand Down
29 changes: 20 additions & 9 deletions src/json-crdt/log/Log.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,19 @@ import {AvlMap} from 'sonic-forest/lib/avl/AvlMap';
import {Model} from '../model';
import {first, next} from 'sonic-forest/lib/util';
import type {Printable} from '../../util/print/types';
import type {JsonNode} from '../nodes/types';

export class Log implements Printable {
/**
* The `Log` represents a history of patches applied to a JSON CRDT model. It
* consists of: (1) a starting {@link Model} instance, (2) a list of {@link Patch} instances,
* that can be applied to the starting model to reach the current state of the
* document, and (3) the current state of the document, the `end` {@link Model}.
*
* The log can be used to replay the history of patches to any point in time,
* from the "start" to the "end" of the log, and return the resulting {@link Model}
* state.
*/
export class Log<N extends JsonNode = JsonNode<any>> implements Printable {
/**
* Creates a `PatchLog` instance from a newly JSON CRDT model. Checks if
* the model API buffer has any initial operations applied, if yes, it
Expand All @@ -16,9 +27,9 @@ export class Log implements Printable {
* `Model.withLogicalClock()` or `Model.withServerClock()`.
* @returns A new `PatchLog` instance.
*/
public static fromNewModel(model: Model<any>): Log {
public static fromNewModel<N extends JsonNode = JsonNode<any>>(model: Model<N>): Log<N> {
const clock = model.clock.clone();
const log = new Log(() => new Model(clock));
const log = new Log<N>(() => new Model(clock));
const api = model.api;
if (api.builder.patch.ops.length) log.end.applyPatch(api.flush());
return log;
Expand All @@ -32,15 +43,15 @@ export class Log implements Printable {
* @readonly Internally this function may be updated, but externally it is
* read-only.
*/
public start: () => Model;
public start: () => Model<N>;

/**
* The end of the log, the current state of the document. It is the model
* instance that is used to apply new patches to the log.
*
* @readonly
*/
public readonly end: Model;
public readonly end: Model<N>;

/**
* The collection of patches which are applied to the `start()` model to reach
Expand All @@ -55,7 +66,7 @@ export class Log implements Printable {
private __onPatch: FanOutUnsubscribe;
private __onFlush: FanOutUnsubscribe;

constructor(start: () => Model) {
constructor(start: () => Model<N>) {
this.start = start;
const end = (this.end = start());
const onPatch = (patch: Patch) => {
Expand Down Expand Up @@ -84,7 +95,7 @@ export class Log implements Printable {
*
* @returns A new model instance with all patches replayed.
*/
public replayToEnd(): Model {
public replayToEnd(): Model<N> {
const clone = this.start().clone();
for (let node = first(this.patches.root); node; node = next(node)) clone.applyPatch(node.v);
return clone;
Expand All @@ -98,7 +109,7 @@ export class Log implements Printable {
* @param ts Timestamp ID of the patch to replay to.
* @returns A new model instance with patches replayed up to the given timestamp.
*/
public replayTo(ts: ITimestampStruct): Model {
public replayTo(ts: ITimestampStruct): Model<N> {
const clone = this.start().clone();
for (let node = first(this.patches.root); node && compare(ts, node.k) >= 0; node = next(node))
clone.applyPatch(node.v);
Expand All @@ -119,7 +130,7 @@ export class Log implements Printable {
for (; node && compare(ts, node.k) >= 0; node = next(node)) newStartPatches.push(node.v);
for (const patch of newStartPatches) this.patches.del(patch.getId()!);
const oldStart = this.start;
this.start = (): Model => {
this.start = (): Model<N> => {
const model = oldStart();
for (const patch of newStartPatches) model.applyPatch(patch);
return model;
Expand Down

0 comments on commit 9aa5923

Please sign in to comment.