Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set ipfs gateway url based on env var #177

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: set ipfs gateway url based on env var #177

merged 1 commit into from
Jan 9, 2025

Conversation

fforbeck
Copy link
Member

@fforbeck fforbeck commented Jan 9, 2025

Context

  • When creating a space, the system will use an environment variable to determine which Gateway is authorized to serve its content. If the environment variable is not defined, the Storacha Production Gateway will be authorized by default.
  • If the Staging Gateway is specified, IPFS links must point to ipfs-staging.w3s.link instead of ipfs.w3s.link. Otherwise, requests will bypass the correct service, preventing proper validation of the content authorization flow.

Changes

  • Refactored the code to dynamically read the IPFS Gateway URL from the environment variable and construct the appropriate URL for content retrieval.
  • Updated deployment configuration files to include the new environment variable for Gateway selection.
  • Resolved a minor compilation issue in nft-storage.ts and web3-storage.ts.

@fforbeck fforbeck requested review from travis and alanshaw January 9, 2025 19:23
@fforbeck fforbeck self-assigned this Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Website preview 🔗✨

build log

@fforbeck fforbeck merged commit 1defed6 into main Jan 9, 2025
5 checks passed
@fforbeck fforbeck deleted the fix/ipfs-url branch January 9, 2025 22:30
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
fforbeck pushed a commit that referenced this pull request Jan 9, 2025
@github-actions
chore(main): release w3console 1.17.2 (#172)
4aebe48 
🤖 I have created a release *beep* *boop*
---


##
[1.17.2](w3console-v1.17.1...w3console-v1.17.2)
(2025-01-09)


### Bug Fixes

* create space ([#173](#173))
([597240f](597240f))
* create space using the latest w3up-client version
([#171](#171))
([600766b](600766b))
* **createSpace:** using the latest w3ui with w3up-client
([#176](#176))
([5194dd2](5194dd2))
* gateway authorization based on env
([#174](#174))
([0eb122d](0eb122d))
* set ipfs gateway url based on env var
([#177](#177))
([1defed6](1defed6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travis travis travis approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees

@fforbeck fforbeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fforbeck @travis