Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using the new client method for space sharing #175

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

fforbeck
Copy link
Member

@fforbeck fforbeck commented Jan 6, 2025

Resolves: storacha/project-tracking#238

The client provides a new method to share a Space via delegation, so we don't need to implement that on the Console App side, we just need to call the new method.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Website preview 🔗✨

build log

@fforbeck fforbeck requested a review from travis January 7, 2025 14:06
Copy link
Member

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- cool big win on simplication :)

@fforbeck fforbeck force-pushed the refactor/share-space branch from 2fd2732 to 2e21364 Compare January 7, 2025 19:49
@fforbeck fforbeck merged commit 64dc68d into main Jan 7, 2025
5 checks passed
@fforbeck fforbeck deleted the refactor/share-space branch January 7, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Console to share space using the w3up-client
2 participants