fix: tweak plan gate query param #163
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we really don't want to show the plan gate if we just finished Stripe checkout - sometimes Stripe isn't fast enough with the webhook so this will help us provide a UX that makes sense even in this case
it turns out Stripe already adds the `checkout.session` query param to this URL - this means we don't even need to update Stripe to fix this!
fforbeck
reviewed
Dec 12, 2024
| @@ -66,7 +66,7 @@ export function PlanGate ({ children }: { children: ReactNode }): ReactNode { | |||
|
|
|||
| export function MaybePlanGate ({ children }: { children: ReactNode }): ReactNode { | |||
| const params = useSearchParams() | |||
| if ((process.env.NEXT_PUBLIC_DISABLE_PLAN_GATE == 'true') || (params.get('checkout') === 'true')) { | |||
| if ((process.env.NEXT_PUBLIC_DISABLE_PLAN_GATE == 'true') || params.get('checkout.session')) { | |||
There was a problem hiding this comment.
Should we check if the checkout was completed?
e.g: https://docs.stripe.com/api/events/types#event_types-checkout.session.completed
There was a problem hiding this comment.
ah so that's a slightly separate thing - the name matches the event names, but the param is actually just set manually in the Stripe pricing table config:
I had been planning on adding checkout as a custom query param but realized we already have checkout.session - we only redirect here if checkout completed so it's essentially what you're suggesting already
Website preview 🔗✨ |
fforbeck
approved these changes
Dec 12, 2024
travis
pushed a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.16.1](w3console-v1.16.0...w3console-v1.16.1) (2024-12-12) ### Bug Fixes * make it possible to skip the plan gate after Stripe checkout ([#162](#162)) ([b399b37](b399b37)) * tweak plan gate query param ([#163](#163)) ([0ce071e](0ce071e)) ### Other Changes * update copy ([#159](#159)) ([0253b05](0253b05)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it turns out Stripe already adds the
checkout.sessionquery param to this URL - this means we don't even need to update Stripe to fix this!