correlation volcano #2620
correlation volcano #2620
Conversation
client/mass/types/mass.ts
Outdated
| termfilter: any | ||
| termdbConfig: { | ||
| correlationVolcano: any |
There was a problem hiding this comment.
this should be optional
| names(output)[3] <- "original_p_value" | ||
| names(output)[4] <- "adjusted_p_value" | ||
| names(output)[5] <- "sample_size" | ||
| cat(paste0("adjusted_p_values:", toJSON(output))) |
There was a problem hiding this comment.
change it to just return stringnified json, rather that nodejs has to cut a line and check what it is
There was a problem hiding this comment.
This makes it easier to print variables inside the R script for debugging. If this is not added, nodejs considers the entire output (including other print statements from R) as JSON which breaks PP during debugging. Most of my other R and rust scripts are designed this way so its easier to debug R and rust codes.
There was a problem hiding this comment.
either use message(msg) to print to stderr (don't do if this throws in node)
or better and i highly prefer this, you should have a test script to run the r script with test data on commandline, that will be more efficient than having to refresh the web browser each time, and be able for script to cleanly return json
Description
Checklist
Check each task that has been performed or verified to be not applicable.