Skip to content

Commit

Permalink
nav should react to plot_prep
Browse files Browse the repository at this point in the history
  • Loading branch information
xzhou82 authored and creilly8 committed Jan 15, 2025
1 parent 8b3f218 commit c820370
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions client/mass/nav.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,12 @@ class TdbNav {
if (action.type.startsWith('filter')) return true
if (action.type.startsWith('cohort')) return true
if (action.type.startsWith('tab')) return true

// do not use startsWith('plot_') to exclude 'plot_edit' as no need for nav to react to that
if (action.type == 'plot_prep') return true
if (action.type == 'plot_create') return true
if (action.type == 'plot_delete') return true

if (action.type == 'app_refresh') return true
if (action.type.endsWith('_customTerm')) return true
if (action.type.endsWith('_group')) return true
Expand Down
2 changes: 2 additions & 0 deletions client/mass/store.js
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,8 @@ TdbStore.prototype.actions = {
})
},

// dispatch "plot_prep" action to produce a 'initiating' UI of this plot, for user to fill in additional details to launch the plot
// example: table, scatterplot which requires user to select two terms
async plot_prep(action) {
const plot = {
id: 'id' in action ? action.id : getId()
Expand Down

0 comments on commit c820370

Please sign in to comment.