Fix response objects returned on Customer functions #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that our
Customer
class functions are returning araw
requestresponse
instead of returning itsdata
field.This PR fixes that so it matches the expected return types for those functions as following:
getCustomer
should return object of typeGetCustomerResponse
add
should return object of typeAddCustomerResponse
update
should return object of typeAddCustomerResponse
All the other class functions on the SDK also follow this same pattern of returning
response.data
field, so let's keep this same pattern for theCustomer
class.It is important to notice that it is a
BREAKING CHANGE
for wallets out there that are using our existingCustomer
class.Note: we need to merge this PR first in order to fix the tests on the Sep-7 PR