CAP-0067 - Emit events at the operation layer #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Is it worth mentioning that meta change is not a protocol change? Technically this doesn't quite belong to CAP as the meta format can be updated independently of the protocol. Probably it's a reasonable place to keep it, but I think it's worth noting that the meta consumers don't have to migrate to the new format immediately after migration? Either way Core will need to support 2 meta formats, and I think it's more reasonable to enable the new contract with a config flag instead of a protocol version (which I'm sure will catch someone off-guard)
dmkozh
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows events to be emitted at the operation level.