Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cap-57 initial draft: State Archival Persistent Entry Eviction #1495

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

SirTyson
Copy link
Contributor

See #1480 for discussion.

@MonsieurNicolas MonsieurNicolas merged commit 7123f85 into stellar:master Jun 26, 2024
3 checks passed
@anupsdf
Copy link
Contributor

anupsdf commented Jun 28, 2024

nit: In the verifyProofOfExistence, the indentation is slightly off where expectedHash == r.hash condition is showing as inside the for loop of proof.entries.

@anupsdf
Copy link
Contributor

anupsdf commented Jun 28, 2024

If an archived entry is restored and the entry currently exists in the Hot Archive, the INITENTRY previously stored in the Hot Archive is overwritten by a RESTORED entry.

How about rephrasing to something like,
If an archived entry is restored and the entry exists in the Hot Archive, then a RESTORED entry is inserted into the Hot Archive bucketlist. This overrides the previously stored INITENTRY in the Hot Archive.

@anupsdf
Copy link
Contributor

anupsdf commented Jun 29, 2024

nit: 4.3% change a single miss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants