SEP-10: Add support for contracts (storage bound) #1492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeUrban
reviewed
Jun 14, 2024
There was a problem hiding this comment.
👏 this was much simpler than I expected.
To confirm, things that would require updates are:
- SDKs
- to use the G-zero address and add the additional manage data op when a C-address is passed as the client account
- fetch the
sep-10-signerskey-val pair from contract storage when validating challenges
- SEP-10 servers
- need to run an RPC to fetch the contract's signers
Comment on lines
+256
to
+258
| - (optional) `manage_data(source: client domain account or G-zero, key: 'client_account', value: client_account e.g. C...)` | ||
| - The source account is the **Client Domain Account** or G-zero | ||
| - Add this operation if the client account is a contract `C...` address |
There was a problem hiding this comment.
I think you intended to update the first operation, the one that contains the client account, but this is the third operation, the one that contains the client domain account (i.e. the wallet's SIGNING_KEY)
Comment on lines
+349
to
+350
| - if the first operation's source account is G-zero, and contains a Manage Data operation with the key `client_account`: | ||
| - use the value of this operation for the client account instead of the source account value |
There was a problem hiding this comment.
So this G-zero account acts as a special case / null value? Clever, I was stuck thinking we would have to support C-addresses as source accounts in order to add them to SEP-10.
leighmcculloch
changed the title
|
Closing in favor of proposing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support for contracts to SEP-10 using storage to store a fixed key.
Why
So that contract accounts can authenticate with SEP-24, SEP-30, etc.
State
This PR is a early draft and idea for how SEP-10 could be modified.
cc @JakeUrban @tomerweller @philipliu @reecexlm @mtwtfss
Related: