SEP-0042 Stellar Asset Lists Standard #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing errors in markdown
…on standard Stellar terminology - Add `feedback`, `description`, `assets.domain` fields - Add "Security Concerns" section - Expand "Design Rationale" section - Add "Composability" and "Consumer UX" sub-sections - Describe versioning strategy
Update from Orbit Lens to include elaboration on various aspects and change name to stellar asset lists Rename Stellar Token Lists to Stellar Asset Lists to follow standard Stellar terminology Add feedback, description, assets.domain fields Add "Security Concerns" section Expand "Design Rationale" section Add "Composability" and "Consumer UX" sub-sections Describe versioning strategy Change some wording
Add SAL JSON schema, fix field description, cleanup formatting
| - [StellarExpert Top50](https://api.stellar.expert/explorer/public/asset-list/top50) asset list for Stellar Pubnet. | ||
| - [StellarExpert Testnet Top50](https://api.stellar.expert/explorer/testnet/asset-list/top50) asset list for Stellar | ||
| Testnet. | ||
|
|
There was a problem hiding this comment.
Can we add a changelog at the bottom, from the sep-template.md?
Suggested change
| ## Changelog | |
| - `v0.2.0`: Initial draft. [#1440](https://github.com/stellar/stellar-protocol/pull/1440) |
|
This pull request is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed. |
@orbitlens @leighmcculloch I had been away for a bit, but am back now... this PR should not go stale, maybe you can remove the label. What do we still need to do in order to implement this? What is the status of the mailing list discussion? Thanks! |
orbitlens
changed the title
…rotocol into sep-0042-token-lists
… terminology, update JSON schema, fix formatting
…rotocol into sep-0042-token-lists
leighmcculloch
approved these changes
Mar 27, 2024
|
Thank you, Leigh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.