Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest/ledgerbackend/configs: Update default captive core config #5564

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jan 6, 2025

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Replace Whalestack with Creit Technologies in default pubnet captive core config.

Why

This will make the quorum set in the default captive core config match the tier 1 validator list:

https://stellarfoundation.slack.com/archives/C02U19A2A/p1735930631316469

Known limitations

[N/A]

@tamirms tamirms requested a review from a team January 6, 2025 17:46
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this config doesn't get loaded by any integration testing correct just for runtime validation, a quick way to confirm this may be horizon --network pubnet I assume?

@sreuland
Copy link
Contributor

sreuland commented Jan 6, 2025

lgtm, this config doesn't get loaded by any integration testing correct just for runtime validation, a quick way to confirm this may be horizon --network pubnet I assume?

oh, nice, there is test coverage on this config , thanks!

@tamirms
Copy link
Contributor Author

tamirms commented Jan 6, 2025

a quick way to confirm this may be horizon --network pubnet I assume?

@sreuland yes, running that command and observing the logs would be the best way to verify that the quorum set is functional.

@tamirms tamirms merged commit 5468720 into stellar:master Jan 6, 2025
23 checks passed
@tamirms tamirms deleted the update-pubnet-cfg branch January 6, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants