clients/stellarcore: Add support for Core's new /getledgerentryraw
#5428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
changed the title
Shaptic
force-pushed
the
new-core-endpoints
branch
from
7b62213 to
e94e43e
Compare
Shaptic
changed the title
/getledgerentry endpoint
Shaptic
force-pushed
the
new-core-endpoints
branch
4 times, most recently
from
f7bc63c to
b8ddb2e
Compare
Shaptic
changed the title
/getledgerentry endpoint/getledgerentryraw
This was
linked to
issues
Sep 17, 2024
Shaptic
force-pushed
the
new-core-endpoints
branch
from
1bc892c to
b80b413
Compare
It'd be nice if we had POST param unit tests but we don't :(
Shaptic
force-pushed
the
new-core-endpoints
branch
from
b80b413 to
144533a
Compare
sreuland
reviewed
Sep 19, 2024
tamirms
reviewed
Sep 21, 2024
tamirms
reviewed
Sep 21, 2024
tamirms
reviewed
Sep 21, 2024
tamirms
reviewed
Sep 21, 2024
tamirms
reviewed
Sep 21, 2024
tamirms
reviewed
Sep 21, 2024
| // GetLedgerEntryRawResponse is the structure of Stellar Core's /getledgerentryraw | ||
| type GetLedgerEntryRawResponse struct { | ||
| Ledger uint32 `json:"ledger"` | ||
| Entries []RawLedgerEntryResponse `json:"entries"` |
There was a problem hiding this comment.
out of curiosity why is each entry a json blob containing one string field instead of simply being a string?
There was a problem hiding this comment.
Not my schema, heh 🤷 @SirTyson?
tamirms
reviewed
Sep 24, 2024
tamirms
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Adds support for a new endpoint:
/getledgerentryraw.Why
Closes #5455.
Note that this endpoint will have the same request format (see #5426 or the PR itself for details) as a bunch of upcoming future endpoints, so for now there is a generic invocation method that can be shared. I reverted their implementation in cd811da, so you can see that adding this commit back would be all we need to do to support them.
Known limitations
Needs end-to-end testing, though basic unit tests are present.