Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingestion: avoid redundant reallocation during streamBucketContents #5097

Conversation

tsachiherman
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

avoid redundant reallocation during streamBucketContents

Why

Existing code was optimized for preloading keys from temp set. However, while this optimization was made, the resizing of the temporary staging buffers was ignored. These could add impactful time and would be easily avoided.

Known limitations

n/a

@tsachiherman tsachiherman self-assigned this Oct 31, 2023
@tsachiherman tsachiherman marked this pull request as ready for review October 31, 2023 18:18
@tsachiherman tsachiherman requested a review from a team October 31, 2023 19:33
@tsachiherman tsachiherman merged commit 7bdbc7b into stellar:release-horizon-v2.27.0 Oct 31, 2023
35 of 36 checks passed
@tsachiherman tsachiherman deleted the tsachi/buffered-change-reader branch October 31, 2023 19:54
tamirms pushed a commit to tamirms/go that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants