Add Phpstan Baseline, increase Level to 5 and "fix" some errors (#68)

* Phpstan Fixes * Add phpstan-baseline
stefanzweifel · Mar 26, 2024 · 6d8f956 · 6d8f956
1 parent a2d61a2
commit 6d8f956
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 4 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -0,0 +1,31 @@
+parameters:
+	ignoreErrors:
+		-
+			message: "#^Unsafe usage of new static\\(\\)\\.$#"
+			count: 2
+			path: src/Exceptions/CannotCreateDbImporter.php
+
+		-
+			message: "#^Unsafe usage of new static\\(\\)\\.$#"
+			count: 1
+			path: src/Exceptions/CliNotFound.php
+
+		-
+			message: "#^Unsafe usage of new static\\(\\)\\.$#"
+			count: 1
+			path: src/Exceptions/DecompressionFailed.php
+
+		-
+			message: "#^Unsafe usage of new static\\(\\)\\.$#"
+			count: 2
+			path: src/Exceptions/ImportFailed.php
+
+		-
+			message: "#^Unsafe usage of new static\\(\\)\\.$#"
+			count: 1
+			path: src/Exceptions/NoBackupsFound.php
+
+		-
+			message: "#^Unsafe usage of new static\\(\\)\\.$#"
+			count: 1
+			path: src/Exceptions/NoDatabaseDumpsFound.php
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -2,7 +2,7 @@ includes:
     - phpstan-baseline.neon
 
 parameters:
-    level: 4
+    level: 5
     paths:
         - src
         - config

diff --git a/src/Commands/RestoreCommand.php b/src/Commands/RestoreCommand.php
@@ -130,9 +130,7 @@ private function getBackupToRestore(string $disk): string
             ->filter(fn ($file) => Str::endsWith($file, '.zip'));
 
         if ($listOfBackups->count() === 0) {
-            if (isset($disk)) {
-                error("No backups found on {$disk}.");
-            }
+            error("No backups found on {$disk}.");
             throw NoBackupsFound::onDisk($disk);
         }
 

diff --git a/src/HealthChecks/Checks/DatabaseHasTables.php b/src/HealthChecks/Checks/DatabaseHasTables.php
@@ -22,6 +22,7 @@ public function run(PendingRestore $pendingRestore): Result
             $tables = $schemaBuilder->getTables();
         } else {
             // `getAllTables()` has been removed in Laravel 11.
+            /** @phpstan-ignore-next-line  */
             $tables = $schemaBuilder->getAllTables();
         }
 

diff --git a/src/PendingRestore.php b/src/PendingRestore.php
@@ -27,6 +27,7 @@ public static function make(...$attributes): PendingRestore
     {
         $restoreName = now()->format('Y-m-d-h-i-s').'-'.Str::uuid();
 
+        /** @phpstan-ignore-next-line */
         return new self(
             ...$attributes,
             restoreName: $restoreName,