Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Don't delete asset if replacing itself #11230

Closed
wants to merge 2 commits into from

Conversation

edalzell
Copy link
Contributor

@edalzell edalzell commented Dec 7, 2024

Closes #11229

@edalzell edalzell changed the title Don't delete asset if replacing itself [5.x] Don't delete asset if replacing itself Dec 7, 2024
@edalzell edalzell requested a review from jesseleite December 7, 2024 05:30
@jasonvarga
Copy link
Member

Thanks for the PR.

With what you've described in #11229, you should be using "reupload" rather than "replace".

You might run into caching issues when uploading an identically named file, and the "reupload" action already tries to handle those as best as it can.

I think we'd be better off updating the validation within the modal for your situation. Or maybe prevent the overwrite option within the "Fix.." dropdown there.

@jasonvarga jasonvarga closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset removed if you replace with same file and "Delete Original" is on, which is the default
2 participants