support multiple directories and files #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: `directory` only allows for one source, not multiple stackrox#13
janisz
reviewed
Jun 8, 2022
There was a problem hiding this comment.
Can you add a test for this change https://github.com/stackrox/kube-linter-action/blob/main/.github/workflows/self-test.yml
janisz
reviewed
Jun 8, 2022
janisz
reviewed
Jun 9, 2022
| branding: | ||
| icon: 'check-circle' | ||
| color: 'green' | ||
| inputs: | ||
| directory: | ||
| description: 'Directory or file to scan' | ||
| description: 'Directories or files to scan separated by spaces' |
There was a problem hiding this comment.
On one hand I like this simple approach of accepting space separated list of dirs but on the other the more natural for yaml will be an array. Can we accept array and us jq to parse it? Does it make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:
directoryonly allows for one source, not multiple #13