New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hang/unhandled exception in SshCommand upon disconnect #1565

Merged

WojciechNagorski merged 1 commit into sshnet:develop from Rob-Hague:cmd-unhandledex

Jan 3, 2025

Collaborator

Rob-Hague commented Jan 1, 2025

Swallow exceptions occurring in the cancellation/timeout callback (due to disconnect) which would result in crash due to UnhandledException
Always complete the Task when cancelling, even when such an exception occurs, in order to avoid the Task never completing. In the case of client disconnect, it would still wait until timeout. This is not ideal since we should be able to complete right away, but at least it's no longer an indefinite hang

contributes to #1561


          Fix hang/unhandled exception in SshCommand upon disconnect

4cc9a6a

Rob-Hague requested review from drieseng and WojciechNagorski as code owners

January 1, 2025 20:21

WojciechNagorski approved these changes

View reviewed changes

WojciechNagorski merged commit 6d94e97 into sshnet:develop

3 checks passed

Rob-Hague deleted the cmd-unhandledex branch

January 3, 2025 10:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet