V6 backports #1986
Open
V6 backports #1986
+29
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenBSD does not have libdl, as it has dlopen() in libc.
It is not really needed, and force-requiring the presence of libdl
causes ./configure to fail on openbsd:
checking for dlopen in -ldl... no
configure: error: Required library 'dl' not found
…1950) Creating a raw pointer with 1 as an address/value raised red flags, and it was difficult to interpret tricky peerRefreshDNS() logic correctly.
…id-cache#1931) ACLExtUser-based ACLs (i.e. ext_user and ext_user_regex) dereferenced a nil request pointer when they were used in a context without a request (e.g., when honoring on_unsupported_protocol). SourceDomainCheck-based ACLs (i.e. srcdomain and srcdom_regex) have a similar bug, although we do not know whether broken slow ACL code is reachable without a request (e.g., on_unsupported_protocol tests cannot reach that code until that directive starts supporting slow ACLs). This change does not start to require request presence for these two ACLs to avoid breaking any existing configurations that "work" without one.
squid-anubis
added
the
M-failed-description
rousskov
reviewed
Jan 20, 2025
| else | ||
| debugs(28, 3, "no request to recordLookup()"); | ||
|
|
||
| checklist->resumeNonBlockingCheck(); |
There was a problem hiding this comment.
This PR incorrectly attributes this resumeNonBLockingCheck() change to PR 1931. That PR (i.e. master/v7 commit 0ef767a) does not change resumeNonBLockingCheck() calls. To backport that commit (without also backporting much more invasive commit 5fb6afe changes), this line/call has to be preserved AFAICT:
Suggested change
| checklist->resumeNonBlockingCheck(); | |
| checklist->resumeNonBlockingCheck(SourceDomainLookup::Instance()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting:
commit 8b31858 : Portability: remove explicit check for libdl
commit dd3292c : Refactor peerRefreshDNS() to clarify its (void*)1 logic
commit 0ef767a: Nil request dereference in ACLExtUser and SourceDomainCheck ACLs