Bug 5092: improve https_port ssl-bump documentation #1981
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinkie
added
the
backport-to-v6
rousskov
requested changes
Jan 13, 2025
Comment on lines
+2307
to
2308
| The ssl_bump configuration option is required to fully enable | ||
| bumping of CONNECT requests. |
There was a problem hiding this comment.
This paragraph is still very misleading IMO. I suggest using one of the following complete replacements (shown here without formatting due to cf.data.pre formatting complications):
- "This option is essentially ignored (with a WARNING) if configuration has no ssl_bump directives."
- "This option is essentially ignored (with a WARNING) unless configuration has ssl_bump directive(s)."
Comment on lines
+2309
to
+2310
| Enabling this option requires also specifying either | ||
| tproxy or intercept |
There was a problem hiding this comment.
This new statement is incorrect: http_port supports SslBump in forward proxy mode as well. That mode is the default.
Suggested change
| Enabling this option requires also specifying either | |
| tproxy or intercept |
Accepting the above suggestion is not enough to address Bug 5092 though.
rousskov
added
the
S-waiting-for-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.