Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GNU'ism in release notes Makefile #1959

Closed
wants to merge 1 commit into from
Closed

Remove GNU'ism in release notes Makefile #1959

wants to merge 1 commit into from

Conversation

yadij
Copy link
Contributor

@yadij yadij commented Dec 10, 2024

Targets containing % wildcard is a GNU automake custom feature.

@yadij
Docs: Remove GNU'ism in release notes Makefile
ccff671 
Targets containing % wildcard is a GNU automake custom feature.
@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels backport-to-v6 maintainer has approved these changes for v6 backporting S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Dec 10, 2024
@rousskov rousskov changed the title Docs: Remove GNU'ism in release notes Makefile Remove GNU'ism in release notes Makefile Dec 10, 2024
rousskov
rousskov approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. I have removed Docs: prefix from PR title because this fix affects build in a fairly significant way (and not just documentation content).

Please focus on advancing PRs that await your review rather than posting new PRs.

squid-anubis pushed a commit that referenced this pull request Dec 12, 2024
@yadij @squid-anubis
Remove GNU'ism in release notes Makefile (#1959)
b615353 
Targets containing % wildcard is a GNU automake custom feature.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Dec 12, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Dec 12, 2024
squidadm pushed a commit to squidadm/squid that referenced this pull request Dec 12, 2024
@yadij @squidadm
Remove GNU'ism in release notes Makefile (squid-cache#1959)
8a918e8 
Targets containing % wildcard is a GNU automake custom feature.
@squidadm squidadm removed the backport-to-v6 maintainer has approved these changes for v6 backporting label Dec 12, 2024
@squidadm
Copy link
Collaborator

queued for backport to v6

kinkie pushed a commit that referenced this pull request Dec 13, 2024
@yadij @kinkie
Remove GNU'ism in release notes Makefile (#1959)
1d33b78 
Targets containing % wildcard is a GNU automake custom feature.
@yadij yadij deleted the rm-docs-gnuism branch December 16, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov rousskov approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yadij @squidadm @rousskov @squid-anubis