Add a StrictMode noteSlowCall for SSL init #8339
Merged
+96
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swankjesse if we don't do #8248, then we should be noisy when it's used on main. |
|
@swankjesse any objections to this? |
JakeWharton
approved these changes
Jan 5, 2025
Comment on lines
+63
to
+65
| .penaltyListener({ it.run() }) { | ||
| violations.add(it) | ||
| } |
There was a problem hiding this comment.
Hmmm. When was this added? I would assume after our minSdk, so it should really have an @SdkSuppress(minSdk=something) on the class.
There was a problem hiding this comment.
I'll check, also why it's not failing if so.
There was a problem hiding this comment.
Ahhh, just the tests. And not running because of mannodermaus/android-junit5#225 and a minSdk 26 requirement for tests.
There was a problem hiding this comment.
Ah. JUnit 5 continues to prove that it's the wrong choice for any project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps may want to defer SSL init off the main thread, so warn if they have enabled Strict Mode.
Alternative or precursor to #8248, should land which ever way that goes.