PR: Remove mutable defaults for keyword arguments #23293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
changed the title
ccordoba12
reviewed
Dec 16, 2024
Comment on lines
+19
to
20
| providers = [] if providers is None else providers | ||
| super().__init__(plugin, parent) |
There was a problem hiding this comment.
Suggested change
| providers = [] if providers is None else providers | |
| super().__init__(plugin, parent) | |
| super().__init__(plugin, parent) | |
| providers = [] if providers is None else providers |
Our custom is not add code before calling super unless it's really necessary.
| max_line_count=300, exitfunc=None, profile=False, | ||
| multithreaded=True): | ||
| commands = [] if commands is None else commands |
There was a problem hiding this comment.
Please move this to be at line 171 below.
Comment on lines
+310
to
+312
| file_associations = ( | ||
| {} if file_associations is None else file_associations | ||
| ) |
There was a problem hiding this comment.
Please move these to be at line 321 below.
Comment on lines
+48
to
+50
| external_path_history = ( | ||
| [] if external_path_history is None else external_path_history | ||
| ) |
There was a problem hiding this comment.
Please move these to be at line 77 below.
There was a problem hiding this comment.
Actually, this can just be removed as there is already a test for an empty list that works equally well for None
Comment on lines
+271
to
272
| data = [] if data is None else data | ||
| QAbstractTableModel.__init__(self, parent) |
There was a problem hiding this comment.
Suggested change
| data = [] if data is None else data | |
| QAbstractTableModel.__init__(self, parent) | |
| QAbstractTableModel.__init__(self, parent) | |
| data = [] if data is None else data |
| """ | ||
| Run Python script in a separate process | ||
| package=None -> module is in sys.path (standard library modules) | ||
| """ | ||
| args = [] if args is None else args | ||
| p_args = [] if p_args is None else p_args | ||
| assert module is not None |
There was a problem hiding this comment.
Suggested change
| assert module is not None | |
| assert module is not None |
For code clarity.
| """Create action to run a GUI based Python script""" | ||
| args = [] if args else args |
There was a problem hiding this comment.
Suggested change
| args = [] if args else args | |
| args = [] if args is None else args |
It seems missing.
| @@ -116,7 +116,8 @@ def __init__(self, parent, handle_links=True, class_parent=None): | |||
| self.setPage(web_page) | |||
| self.source_text = '' | |||
|
|
|||
| def setup(self, options={}): | |||
| def setup(self, options=None): | |||
| options = {} if options is None else options | |||
There was a problem hiding this comment.
Suggested change
| options = {} if options is None else options | |
| options = {} if options is None else options | |
For clarity.
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Whilst tracking down an odd race condition in locating conda, I spotted several instances where a mutable type
was being used as a default for a keyword argument. This PR simple replaces the mutable constant (typically [] and {})
with a
Noneand then does anx = [] if x is None else xor equivalent on the first line of each affected function.It is possible that functionality was depending on the default mutable value being changed by a function call, but
I'd argue that it is sufficiently non-obvious that doing that should be considered a bug :-)
Issue(s) Resolved
Partially Fixes #23061
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: gb119 (https://github.com/gb119)