PR: Raise timeout threshold for getting user environment variables #23278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrclary
force-pushed
the
env-var-timeout
branch
from
97ce9a7 to
6889041
Compare
mrclary
force-pushed
the
env-var-timeout
branch
2 times, most recently
from
82d24cd to
b9c2b90
Compare
…o ensure next call will retrieve the new change
mrclary
force-pushed
the
env-var-timeout
branch
from
b9c2b90 to
8d1c172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I've run into an scenario where
get_user_environment_variablescan take up to ~1s. This triggers the timeout and renders the function useless.I propose raising the timeout to 3s for all scenarios and, in deference to #21172, caching the result.
On startup,
get_user_environment_variablesis called 8 times (!). If it takes ~0.5s without timeout, then it will cost in total 4s at startup. Raising the timeout to 3s will cost in total at most 3s (in extreme cases), so I think this is a good tradeoff.