Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add H2 specific SessionRepositoryCustomizer #2828

Conversation

repolevedavaj
Copy link

This PR introduces a SessionRepositoryCustomizer for H2. The implementation is quite similar to the one for Oracle. The only difference is the needed datatype casts for the parameters.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 1, 2024
@repolevedavaj repolevedavaj force-pushed the feature/h2-jdbc-session-repo-customizer branch from 1576abf to 1289723 Compare March 1, 2024 20:04
@marcusdacoregio marcusdacoregio self-assigned this Mar 5, 2024
@marcusdacoregio marcusdacoregio removed the status: waiting-for-triage An issue we've not yet triaged label Mar 5, 2024
@marcusdacoregio
Copy link
Contributor

Hi, @repolevedavaj. Thanks for the PR.

Can you elaborate more why such customizer is needed? Does it also work if H2 compability mode is set to Postgres, for example?

@repolevedavaj
Copy link
Author

repolevedavaj commented Mar 6, 2024

Hi, @repolevedavaj. Thanks for the PR.

Can you elaborate more why such customizer is needed? Does it also work if H2 compability mode is set to Postgres, for example?

Hi @marcusdacoregio, I created the customizer as the existing ones were not working with a H2 database, even in compatibility mode. I am using the Postgres one in production and the H2 one while executing tests. I did not test it specifically if it works in Postgres compatibility mode.

@marcusdacoregio
Copy link
Contributor

I think that there is uncertainty whether this customizer will work fine with any combination of H2's configurations and there is no easy way for us to test it, therefore I think it would be better to not add it now. If we receive more reports asking for an H2 customizer, we can combine the use-cases and provide one. Does that sound ok for you?

@repolevedavaj
Copy link
Author

Hi @marcusdacoregio, I see your point. According to H2, the used syntax is not depending on a specific mode, but I don't know if it behaves differently with in specific modes. For me its fine to close the PR as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: jdbc type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants