improve the setup description #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 85.83% 84.84% -0.99%
==========================================
Files 3 3
Lines 120 132 +12
Branches 28 35 +7
==========================================
+ Hits 103 112 +9
- Misses 17 20 +3
Continue to review full report at Codecov.
|
vanesa
changed the title
Clean up code, update comments and readme, use URL API for repo extraction, match with any throw new TypeError()
…issing configurations, update tests
There was a problem hiding this comment.
Approving because I didn't find any logic bugs and none of my comments are blocking.
- I'm not sure why there's both a
package-lock.jsonandyarn.lock, but I'dgit rm package-lock.json - I'm not sure why there are renovate commits in this branch. Maybe you merged master into this branch at some point? If you
git rebase masterfrom the command line instead, you won't end up with such commits here. Not that it's a problem, it's just a minor distraction during review.
There was a problem hiding this comment.
I wish this only included setup description improvements, and not also escaping fixes + various code/test fixes. In the context of this PR ("improve setup description"), consider my comments on docs blocking, and please address comments on code changes in smaller, atomic follow-up PRs.
In general, stick to the one PR - one concern doctrine (or SRPRP, "Single Responsibility Pull Request Principle" - which I totally didn't just make up).
Co-Authored-By: Loic Guychard <[email protected]>
| - Python | ||
| - Java | ||
| - TypeScript, JavaScript ( e.g. `throw new Error()`, `console.error()`) | ||
| - Go ( e.g. `err.message()`) |
There was a problem hiding this comment.
I've never seen this code in Go. Do you mean something like error.New()?
|
|
||
| File patterns can also be narrowed down to certain folders by specifying this in the RegExp: | ||
| Some organizations have multiple Sentry projects that capture errors from various repositories within their organization. Inside each Sentry project, use repository `filters` like so: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Make this json for syntax highlighting (other codeblocks too)
Improve the setup description for the Sentry extension to ensure better user experience.
Also solves these issues: