add more tests, use the Sourcegraph stubs api and improve repo matching. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguychard
suggested changes
Apr 24, 2019
src/test/extension.test.ts
Outdated
|
|
||
| describe('extension', () => { | ||
| it('works', () => void 0) | ||
| }) | ||
|
|
||
| describe('check for extension activation', () => { | ||
| it('activate extension', () => expect(activate(sourcegraph.ExtensionContext)).toEqual(void 0)) |
There was a problem hiding this comment.
This works in that it checks that the extension's activate function does not crash when called. However it doesn't test much beyond that. I would add more comprehensive tests for the actual functionality, for instance:
- The extension reacts to windows/editor changes and decorates editors accordingly
- The extension reacts to configuration changes and decorates editors accordingly
…urcegraph-sentry into vo/increase-test-coverage
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 75.72% 85.12% +9.39%
==========================================
Files 3 3
Lines 103 121 +18
Branches 20 29 +9
==========================================
+ Hits 78 103 +25
+ Misses 25 18 -7
Continue to review full report at Codecov.
|
chrismwendt
reviewed
May 9, 2019
Co-Authored-By: Felix Becker <[email protected]>
Co-Authored-By: Felix Becker <[email protected]>
Co-Authored-By: Felix Becker <[email protected]>
vanesa
changed the title
lguychard
suggested changes
May 16, 2019
linePatterns, repositories and files were typed as RegExp[], but the user would have actually entered them as string[]. Having them typed as RegExp[] hid potential bugs where their real type would not have been handled properly.
lguychard
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Sourcegraph stubs api for testing, improve repo matching.