feat: use waitForSelector to prevent flakes

sourcegraph · Apr 1, 2022 · b2bc64c · b2bc64c
1 parent 8891364
commit b2bc64c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/web-functionality/src/index.ts b/packages/web-functionality/src/index.ts
@@ -26,7 +26,7 @@ const handler = async (): Promise<void> => {
             await runTests()
             break
         } catch (error) {
-            console.error(`Failed attempt ${index}:`, error)
+            console.error(`Failed attempt ${index + 1}:`, error)
             if (index === 2) {
                 process.exit(error?.exitCode || 1)
             }

diff --git a/packages/web-functionality/src/smoke.test.ts b/packages/web-functionality/src/smoke.test.ts
@@ -9,6 +9,7 @@ describe('Smoke tests', () => {
 
     it('successful runs a search', async () => {
         // Update search input
+        await page.waitForSelector('.test-query-input textarea')
         await expect(page).toFill(
             '.test-query-input textarea',
             'repo:^github.com/sourcegraph/smoke-tests-test-repository$'
@@ -18,6 +19,9 @@ describe('Smoke tests', () => {
         await expect(page).toClick('.test-search-button')
 
         // Expect results count is shown correctly
-        await expect(page).toMatchElement('[data-testid="streaming-progress-count"]', { text: '1 result' })
-    }, 5000) // Bigger timeout is required to avoid flakes. Default is 500ms.
+        await page.waitForSelector('[data-testid="streaming-progress-count"]')
+        await expect(page).toMatchElement('[data-testid="streaming-progress-count"]', {
+            text: '1 result',
+        })
+    })
 })