Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Prepare for v0.3.2 release #218

Merged
merged 1 commit into from
Nov 3, 2023
Merged

docs: Prepare for v0.3.2 release #218

merged 1 commit into from
Nov 3, 2023

Conversation

mrnugget
Copy link
Contributor

@mrnugget mrnugget commented Nov 3, 2023

Preparing 0.3.2 with #217 so I can update it in sourcegraph/sourcegraph.

Test plan

  • CI and ran cargo tests locally.

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Side-comment about the usage of a changelog.md, I'd love to just be able to push a git tag without a PR updating the changelog and bumping up the cargo.toml file.

@mrnugget
Copy link
Contributor Author

mrnugget commented Nov 3, 2023

go tests failing, taking a look.

@mrnugget
Copy link
Contributor Author

mrnugget commented Nov 3, 2023

Fixed and updated Development.md to add that task.

@mrnugget mrnugget merged commit c108923 into main Nov 3, 2023
4 checks passed
@mrnugget mrnugget deleted the mrn/release-0.3.2 branch November 3, 2023 13:10
CHANGELOG.md Show resolved Hide resolved
Development.md Show resolved Hide resolved
@mrnugget
Copy link
Contributor Author

mrnugget commented Nov 3, 2023

@varungandhi-src
Copy link
Contributor

varungandhi-src commented Nov 3, 2023

I'd love to just be able to push a git tag without a PR updating the changelog and bumping up the cargo.toml file.

Having a hand-written change log seems more useful than having an automatically generated one from PR titles/commit messages... And the marginal effort to create a small PR doesn't seem that high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants