Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site_config.mdx #879

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Update site_config.mdx #879

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92807a2
Update site_config.mdx
mibali Dec 30, 2024
5cf1185
Update site_config.mdx
mibali Jan 2, 2025
58ffa86
Update site_config.mdx
mibali Jan 7, 2025
c9b7918
Update site_config.mdx
mibali Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions docs/admin/config/site_config.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ All site configuration options and their default values are shown below.
// Disk usage threshold at which to display warning notification. Value is a percentage.
"gitserver.diskUsageWarningThreshold": 90,

// Configuration for logging and alerting, including to external services.
// Configuration for logging and alerting, including to external s.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what "external s" means in this context. From the rest of this PR it seems that this is in reference to Slack?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If my assumption that we're simply updating the Slack hooks URL due to a change on Slack's end then we don't have to change this messaging to "external s" we can keep "external services".

Again, if I'm misunderstanding something please fill in the gap for me here.

"log": null,

// Notifications recieved from Sourcegraph.com to display in Sourcegraph.
Expand All @@ -220,7 +220,7 @@ All site configuration options and their default values are shown below.
// "notifier": {
// "channel": "#alerts",
// "type": "slack",
// "url": "https://hooks.slack.com/services/..."
// "url": "https://hooks.slack.com/s/..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would seem that Slack has updated their hooks URL?

If that is what we're trying to fix it would be helpful to have a reference for this change (reply to this comment with it).

// }
// }
// - {
Expand Down Expand Up @@ -304,9 +304,12 @@ All site configuration options and their default values are shown below.
// Don't sync a user's permissions if they have synced within the last n seconds.
"permissions.syncUsersBackoffSeconds": 60,

// The maximum number of user-centric permissions syncing jobs that can be spawned concurrently. Service restart is required to take effect for changes.
// The maximum number of user-centric permissions syncing jobs that can be spawned concurrently. Server restart is required for changes to take effect.
"permissions.syncUsersMaxConcurrency": 1,

// The maximum number of repo-centric permissions syncing jobs that can be spawned concurrently. Server restart is required for changes to take effect.
"permissions.syncReposMaxConcurrency": 5,

"rateLimits": null,

// Enables redacting sensitive information from outbound requests. Important: We only respect this setting in development environments. In production, we always redact outbound requests.
Expand Down
Loading