Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 5.11.x] Comment out runAsUser and runAsGroup in values.yaml #626

Merged
merged 1 commit into from
Jan 24, 2025
+8 −6
Merged

[Backport 5.11.x] Comment out runAsUser and runAsGroup in values.yaml #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/sourcegraph-executor/k8s/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ In addition to the documented values, the `executor` and `private-docker-registr
| executor.kubernetesJob.resources.limits.memory | string | `"12Gi"` | The maximum memory for a job. |
| executor.kubernetesJob.resources.requests.cpu | string | `""` | The requested CPU for a job. |
| executor.kubernetesJob.resources.requests.memory | string | `"1Gi"` | The requested memory for a job. |
| executor.kubernetesJob.runAsGroup | int | `-1` | The group ID to run Kubernetes jobs as. |
| executor.kubernetesJob.runAsUser | int | `-1` | The user ID to run Kubernetes jobs as. |
| executor.kubernetesJob.runAsGroup | int | `nil`; accepts [0, 2147483647] | The group ID to run Kubernetes jobs as. |
| executor.kubernetesJob.runAsUser | int | `nil`; accepts [0, 2147483647] | The user ID to run Kubernetes jobs as. |
| executor.log.format | string | `"condensed"` | |
| executor.log.level | string | `"warn"` | Possible values are `dbug`, `info`, `warn`, `eror`, `crit`. |
| executor.log.trace | string | `"false"` | |
Expand Down
10 changes: 6 additions & 4 deletions charts/sourcegraph-executor/k8s/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,12 @@ executor:
kubernetesJob:
# -- The number of seconds after which a Kubernetes job will be terminated.
deadline: "1200"
# -- The user ID to run Kubernetes jobs as.
runAsUser: -1
# -- The group ID to run Kubernetes jobs as.
runAsGroup: -1
# -- (int) The user ID to run Kubernetes jobs as.
# @default -- `nil`; accepts [0, 2147483647]
runAsUser:
# -- (int) The group ID to run Kubernetes jobs as.
# @default -- `nil`; accepts [0, 2147483647]
runAsGroup:
# -- The group ID which is set on the job PVC file system.
fsGroup: "1000"
resources:
Expand Down
Loading