Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit tests to be current with most recent helm unittest syntax #619

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Update unit tests to be current with most recent helm unittest syntax #619

merged 2 commits into from
Jan 17, 2025

Conversation

peterguy
Copy link
Contributor

@peterguy peterguy commented Jan 16, 2025 •
edited
Loading

  • Switch to the canonical helm unittest isntead of an outdated fork.
  • Update the tests to work with latest syntax.

Checklist

Test plan

  1. uninstall the outdated helm unittest fork: helm plugin uninstall unittest
  2. install the canonical tool: helm plugin install https://github.com/helm-unittest/helm-unittest
  3. run the unit tests: helm unittest ./charts/sourcegraph/.

@peterguy peterguy self-assigned this Jan 16, 2025
@peterguy peterguy marked this pull request as ready for review January 16, 2025 22:29
@peterguy peterguy changed the title Update unit tests to be current with most recent helm unittest syntax and expectations. Update unit tests to be current with most recent helm unittest syntax Jan 16, 2025
@peterguy peterguy enabled auto-merge (squash) January 16, 2025 22:44
jdpleiness
jdpleiness approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@jdpleiness jdpleiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterguy thanks for going through and updating all these tests! 🙇

@peterguy peterguy merged commit d1b1a39 into main Jan 17, 2025
7 checks passed
@peterguy peterguy deleted the peterguy/update-unit-tests branch January 17, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpleiness jdpleiness jdpleiness approved these changes

@burmudar burmudar Awaiting requested review from burmudar

Assignees

@peterguy peterguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterguy @jdpleiness