-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add references to sslmode for postgres dbs #617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chickensoupwithrice
requested review from
jdpleiness,
marcleblanc2 and
DaedalusG
January 17, 2025 00:03
Chickensoupwithrice
force-pushed
the
al/REL-638/pg-ssl-mode
branch
from
January 17, 2025 00:27
2fd967e
to
0e95126
Compare
jdpleiness
approved these changes
Jan 17, 2025
[REL-638](https://linear.app/sourcegraph/issue/REL-638/configure-aws-rds-databases-for-tls-connections-in-helm-chart) raised issues that this flag did not get mentioned in the docs where a customer wanted to use TLS. It also outlined the recommended fixes that this commit implements.
- update pgsql secret checksum - codeinsights db checksum - codeintel db checksum - pgsqlAuth test checksum - the other pgsql checsum...
Chickensoupwithrice
force-pushed
the
al/REL-638/pg-ssl-mode
branch
from
January 17, 2025 17:27
0e95126
to
563eb4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REL-638
raised issues that this flag did not get mentioned in the docs where a
customer wanted to use TLS. It also outlined the recommended fixes that
this commit implements.
This PR has an accompanying docs PR
Checklist
Test plan
Manually test this out? Would require spinning up an RDS instance or something, but that's fine.
I'm in the process of doing so now.