feat(sourcegraph): add support to scale worker horizontally #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaellzc
force-pushed
the
11-20-feat_sourcegraph_add_support_to_scale_worker_horizontally
branch
2 times, most recently
from
090699e to
99dc046
Compare
michaellzc
force-pushed
the
11-20-feat_sourcegraph_add_support_to_scale_worker_horizontally
branch
from
99dc046 to
ef05c2b
Compare
michaellzc
commented
Nov 20, 2024
Comment on lines
+53
to
+140
| - it: should have the correct worker-0 deployment | ||
| template: worker/worker.Deployment.yaml | ||
| set: | ||
| worker: | ||
| resources: | ||
| limits: | ||
| cpu: "2" | ||
| memory: 4G | ||
| requests: | ||
| cpu: 500m | ||
| memory: 2G | ||
| replicas: | ||
| - jobs: ["job1", "job2"] | ||
| - jobs: ["job3", "job4"] | ||
| documentIndex: 1 | ||
| asserts: | ||
| - containsDocument: | ||
| kind: Deployment | ||
| apiVersion: apps/v1 | ||
| name: worker-0 | ||
| - contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: WORKER_JOB_ALLOWLIST | ||
| value: job1,job2 | ||
| - notContains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: WORKER_JOB_BLOCKLIST | ||
| - equal: | ||
| path: spec.selector.matchLabels.worker-replica | ||
| value: worker-0 | ||
| - equal: | ||
| path: spec.template.metadata.labels.worker-replica | ||
| value: worker-0 | ||
| - equal: | ||
| path: spec.template.spec.containers[0].resources | ||
| value: | ||
| limits: | ||
| cpu: "2" | ||
| memory: 4G | ||
| requests: | ||
| cpu: 500m | ||
| memory: 2G | ||
| - it: should have the correct worker-1 deployment | ||
| template: worker/worker.Deployment.yaml | ||
| set: | ||
| worker: | ||
| replicas: | ||
| - jobs: ["job1", "job2"] | ||
| - jobs: ["job3", "job4"] | ||
| resources: | ||
| limits: | ||
| cpu: 2000m | ||
| memory: 4Gi | ||
| requests: | ||
| cpu: 2000m | ||
| memory: 4Gi | ||
| documentIndex: 2 | ||
| asserts: | ||
| - containsDocument: | ||
| kind: Deployment | ||
| apiVersion: apps/v1 | ||
| name: worker-1 | ||
| - contains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: WORKER_JOB_ALLOWLIST | ||
| value: job3,job4 | ||
| - notContains: | ||
| path: spec.template.spec.containers[0].env | ||
| content: | ||
| name: WORKER_JOB_BLOCKLIST | ||
| - equal: | ||
| path: spec.selector.matchLabels.worker-replica | ||
| value: worker-1 | ||
| - equal: | ||
| path: spec.template.metadata.labels.worker-replica | ||
| value: worker-1 | ||
| - equal: | ||
| path: spec.template.spec.containers[0].resources | ||
| value: | ||
| limits: | ||
| cpu: 2000m | ||
| memory: 4Gi | ||
| requests: | ||
| cpu: 2000m | ||
| memory: 4Gi |
eseliger
approved these changes
Nov 20, 2024
filiphaftek
approved these changes
Nov 20, 2024
michaellzc
force-pushed
the
11-20-feat_sourcegraph_add_support_to_scale_worker_horizontally
branch
from
ef05c2b to
f8d5e61
Compare
michaellzc
deleted the
11-20-feat_sourcegraph_add_support_to_scale_worker_horizontally
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref CLO-1023
https://sourcegraph.com/docs/admin/workers#3-split-jobs-and-scale-independently
workeris not really horizontally scalable, and it requires manually creating additionallyworkerdeployments with the correctWORKER_JOB_ALLOWLISTandWORKER_JOB_BLOCKLISTenvironment variable.This PR added native support for managing multiple worker deployment through helm template.
By default, it will work as is to day with a single
workerdeployment. To enable additional dedicated worker, user can specify the following overrides:This will create 3 distinct worker deployment (
worker,worker-0, andworker-1) with the correctWORKER_JOB_*env var. Additinoally, we also support overriding replica specific resources config. See unit test for more information.Checklist
Test plan
CI, and manual testing with
all pods are healthy
you can also play around with
helm template --debug -f ./override.yaml sourcegraph charts/sourcegraph/.and inspect the rendered YAML