Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcegraph: add priority class support to redis deployment #581

Merged
merged 2 commits into from
Nov 20, 2024
Merged

sourcegraph: add priority class support to redis deployment #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd40af6
redis deployments: add priority class support
filiphaftek Nov 19, 2024
2daf17b
unit tests
filiphaftek Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/sourcegraph/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Use `**BREAKING**:` to denote a breaking change
## Unreleased

- Updated OpenTelemetry collector and agent images to run as non-root users [#543](https://github.com/sourcegraph/deploy-sourcegraph-helm/pull/543)
- redis cache and redis store deployments support priority class

## 5.6.185

Expand Down
3 changes: 3 additions & 0 deletions charts/sourcegraph/templates/redis/redis-cache.Deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- include "sourcegraph.renderServiceAccountName" (list . "redisCache") | trim | nindent 6 }}
{{- if .Values.redisCache.priorityClassName }}
priorityClassName: {{ .Values.redisCache.priorityClassName }}
{{- end }}
volumes:
- name: redis-data
persistentVolumeClaim:
Expand Down
3 changes: 3 additions & 0 deletions charts/sourcegraph/templates/redis/redis-store.Deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- include "sourcegraph.renderServiceAccountName" (list . "redisStore") | trim | nindent 6 }}
{{- if .Values.redisStore.priorityClassName }}
priorityClassName: {{ .Values.redisStore.priorityClassName }}
{{- end }}
volumes:
- name: redis-data
persistentVolumeClaim:
Expand Down
20 changes: 19 additions & 1 deletion charts/sourcegraph/tests/priorityClass_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,22 @@ tests:
asserts:
- equal:
path: spec.template.spec.priorityClassName
value: symbols-class
value: symbols-class
- it: set priority class on redisCache
template: redis/redis-cache.Deployment.yaml
set:
redisCache:
priorityClassName: redis-cache-class
asserts:
- equal:
path: spec.template.spec.priorityClassName
value: redis-cache-class
- it: set priority class on redisStore
template: redis/redis-store.Deployment.yaml
set:
redisStore:
priorityClassName: redis-store-class
asserts:
- equal:
path: spec.template.spec.priorityClassName
value: redis-store-class
Loading