monitoring: postgres metrics #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emidoots
reviewed
Nov 26, 2019
| --restart=always \ | ||
| --cpus=1 \ | ||
| --memory=1g \ | ||
| -e DATA_SOURCE_NAME="postgresql://sourcegraph:sourcegraphd@pgsql:5432/postgres?sslmode=disable" \ |
There was a problem hiding this comment.
@uwedeportivo Can a user specify PG* variables here individually instead of a DSN? Composing the DSN requires hard-coding the password or some weird trickery if it contains values that need to be URL-encoded
I imagine the same would be true in deploy-sourcegraph; we should probably just use the PG* variables mirroring the frontend
emidoots
reviewed
Nov 26, 2019
| @@ -21,3 +21,5 @@ | |||
| - gitserver-0:6060 | |||
| - searcher-0:6060 | |||
| - symbols-0:6060 | |||
| - postgres-exporter:9187 | |||
There was a problem hiding this comment.
This line should go below lsif-server on line 18; the area you put it are for entries that must be duplicated for multiple replicas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes Prometheus target postgres_exporter that publishes Postgres metrics of an associated Postgres instance.
Related to https://github.com/sourcegraph/sourcegraph/pull/6616