Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not filter out path-only results #6549

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

camdencheek
Copy link
Member

@camdencheek camdencheek commented Jan 8, 2025

The API supports searching for file paths and returns the results correctly, but the client was filtering them out of the results. This removes that filter.

Fixes SRCH-1514

Test plan

CleanShot 2025-01-07 at 17 02 04@2x

@camdencheek camdencheek marked this pull request as ready for review January 8, 2025 00:02
Copy link
Member

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@camdencheek camdencheek enabled auto-merge (squash) January 8, 2025 00:15
@camdencheek camdencheek merged commit e6053bc into main Jan 8, 2025
21 checks passed
@camdencheek camdencheek deleted the cc/fix-no-path-results branch January 8, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants