feat(auto-edits): clean auto-edits output channel #6547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitesh-1997
commented
Jan 7, 2025
| this.logger = new Logger(feature) | ||
| } | ||
|
|
||
| logDebugIfVerbose(filterLabel: string, text: string, ...args: unknown[]): void { |
There was a problem hiding this comment.
@valerybugakov do you think we should remove it and just logDebug them. In case any user faces some issue, they can share the logs with us (since atleast initial string will be present in logDebug)
There was a problem hiding this comment.
Let's merge it as-is and iterate through follow-up PRs. Moving some of the logs under the verbose flag is the right move. In most cases, non-verbose logs should be sufficient, and enabling verbose logging should be straightforward for users.
valerybugakov
approved these changes
Jan 8, 2025
|
|
||
| constructor(feature: string) { | ||
| super(feature) | ||
| this.logger = new Logger(feature) |
There was a problem hiding this comment.
Nit: extending the logger should be enough; there's no need to create an internal instance of the parent. We can still access its methods from this instance. I'll create a small patch for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Clean the output logger for
auto-edits:auto-editsmight break are enabled only if verbose debugging true.promptare shorted similar to autocomplete prompt logs.Logs when verbose enabled for a single
auto-editsrequest.Logs without verbose enabled for a single
auto-editsrequest.Test plan
cody.debug.versionflag