feat(autoedits): make it reactive to config changes #6537
Conversation
hitesh-1997
force-pushed
the
hitesh/make-autoedits-reactive
branch
from
2018bc0 to
0f22a0e
Compare
valerybugakov
changed the title
| distinctUntilChanged((a, b) => { | ||
| return ( | ||
| isEqual(a[0].configuration, b[0].configuration) && | ||
| isEqual(a[1], b[1]) && | ||
| isEqual(a[2], b[2]) | ||
| ) | ||
| }), |
There was a problem hiding this comment.
simply copied from registerAutocomplete anything wrong with this approach 😅
There was a problem hiding this comment.
Yeah, I think there's a TODO to address it. We should look into it at some point.
| return promiseFactoryToObservable(async () => { | ||
| return await getAutoeditsProviderDocumentFilters() | ||
| }).pipe( |
There was a problem hiding this comment.
Since we don't have a setting for languages that autoedits are enabled for, we can use a static list for now without the promiseFactoryToObservable call.
vscode/src/main.ts
Outdated
| }) | ||
| }), | ||
| catchError(error => { | ||
| logError('registerAutoedits', 'Error', error) |
There was a problem hiding this comment.
Can we use autoeditsOutputChannelLogger here to ensure this message is added to the autotedits output channel in the dev environment?
vscode/src/configuration.ts
Outdated
| @@ -68,7 +74,7 @@ export function getConfiguration( | |||
| debugVerbose: config.get<boolean>(CONFIG_KEY.debugVerbose, false), | |||
| debugFilter: debugRegex, | |||
| telemetryLevel: config.get<'all' | 'off'>(CONFIG_KEY.telemetryLevel, 'all'), | |||
| autocomplete: config.get(CONFIG_KEY.autocompleteEnabled, true), | |||
| autocomplete: codyAutoSuggestionsMode === CodyAutoSuggestionMode.Autocomplete, | |||
There was a problem hiding this comment.
Should we migrate settings from people with the old configuration field in their settings.json? If I have "cody.autocomplete.enabled": false in my settings I expect CONFIG_KEY.suggestionsMode to be false too when I upgrade to the new version. WDYT?
There was a problem hiding this comment.
Ah yes, sorry I missed this.
Should we add a manual override here ?
There was a problem hiding this comment.
Can we programmatically migrate the current setting value to a new field? For example, if autocomplete.enabled is set to false, suggestions.mode should be manually updated to off. Also, let's create an issue to follow up and remove this code later.
There was a problem hiding this comment.
Added override and create issue: https://linear.app/sourcegraph/issue/CODY-4631/remove-backward-compatibility-override-for-autocomplete-after
Context
Currently
auto-editsis not reactive to config changes and hence requires vscode reloading. If the user doesn't reload vscodeauto-editssuggestion doesn't do away because theauto-editsprovider is notdisposedon the config change.This results into:
auto-editssuggestions.auto-editstoautocompletemode, they will see the suggestion from bothautocompleteandauto-edits.auto-editsreactive to theauthStatusandconfigchange similar toautocomplete, so thatauto-editsis reactive and destroyed/created on the config changes without reloading vscode.Example image below:
Test plan
disposefunction andprovideInlineCompletionfunction forautocompleteandauto-editsand make sure they are disposed and created upon config changes without reloading vscode.