Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Css logic to correctly show rate limit banners in the correct place #6464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing Css logic to correctly show rate limit banners in the correct place #6464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions vscode/webviews/chat/ErrorItem.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,12 @@
}

.error-item .banner-container {
position: absolute;
position: relative;
top: 0;
right: 0;
overflow: hidden;
overflow: visible;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this container has 100px, but with overflow visible, it doesn't make much sense to have a fixed height because, with the visible value, it will overflow anyway.

height: 100px;
z-index: 1000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We (usually) don't use z-index greater than 0 or 1, I would try to solve this with isolation instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pointer, I will respond after getting the opinion of the whole situation from @toolmantim and @taiyab

}

@property --error-item-reflection-position {
Expand Down
Loading