Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding agentVersion clientPlatform to OpenTelemetryService #6436

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arafatkatze
Copy link
Collaborator

@arafatkatze arafatkatze commented Dec 21, 2024

We have agent version and ClientPlatform in OpenTelemetryService

Test plan

Tested locally with an otel collector
image

Changelog

Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add this because it is confusing.

AFAIK, we get this agent version from package.json. But that is inaccurate for VSCode insider builds, because it just identifies the previous stable version (typically.)

Also for the JetBrains stable release, we have been making the stable release as a respin of the last prerelease without necessarily merging the package.json changes.

If we can make the agent versions accurate, that's great. But let's not log something that is probably wrong or at least confusing.

@arafatkatze
Copy link
Collaborator Author

@dominiccooney So I talked to @abeatrix and turns out that the package.json for the insiders-release and proper release is automatically adjusted and that writes the value of agentExtensionVersion and you can see that in the cody settings too

image

See related code

NOTE: We already have these being emitted in Webviewopentelemetry service so we have this in honeycomb

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants