Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context on the chatsController.activeEditor TODO item #6246

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add more context on the chatsController.activeEditor TODO item #6246

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aad9b24
Add an optional submitType arg to submitChat() in ChatsController
ykdojo Oct 24, 2024
48cc7da
fix typo
ykdojo Oct 24, 2024
88866a7
Add the 'continue-chat' submitType in terminal.ts
ykdojo Oct 24, 2024
3df06e5
Run clearAndRestartSession only when we're starting new chat
ykdojo Oct 24, 2024
9d6a4c2
Merge branch 'main' into explain-command-in-context-2
ykdojo Nov 25, 2024
dadcbda
Merge branch 'main' into explain-command-in-context-2
ykdojo Dec 3, 2024
d53b5a4
feat(chat): add context for activeEditor handling in ChatsController
ykdojo Dec 3, 2024
55fb8de
Merge branch 'main' into explain-command-in-context-2
ykdojo Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vscode/src/chat/chat-view/ChatsController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@ export class ChatsController implements vscode.Disposable {
// For now, always use the side panel if it's visible.
// TODO: Let activeEditor be able to become this.panel,
// thus handling both the side panel and a webview panel the same way.
// More info: https://drive.google.com/file/d/19cjIgFq8Wthfzjen0nWykqZybxWw4dYx/view?usp=sharing
} else if (submitType === 'continue-chat' && this.panel.isVisible()) {
provider = this.panel
} else if (submitType === 'continue-chat' && this.activeEditor?.webviewPanelOrView?.visible) {
Expand Down
Loading