-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bundle size limits and tracking to Github CLI #6222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arafatkatze
force-pushed
the
adding-bundle-size-measures
branch
from
November 29, 2024 09:32
e4d5921
to
7911310
Compare
arafatkatze
force-pushed
the
adding-bundle-size-measures
branch
from
November 29, 2024 10:27
382c2fa
to
9404e1e
Compare
arafatkatze
force-pushed
the
adding-bundle-size-measures
branch
5 times, most recently
from
December 9, 2024 09:05
cc4e0dc
to
9c58e26
Compare
kalanchan
reviewed
Dec 9, 2024
arafatkatze
force-pushed
the
adding-bundle-size-measures
branch
from
December 10, 2024 07:46
d27b8aa
to
501e933
Compare
arafatkatze
force-pushed
the
adding-bundle-size-measures
branch
from
December 12, 2024 18:08
9a5cd1e
to
cb784ad
Compare
Add size limit enforcement and historical tracking for extension bundles to prevent unexpected size increases. This helps maintain performance and download speeds for users.
arafatkatze
force-pushed
the
adding-bundle-size-measures
branch
from
December 12, 2024 18:08
cb784ad
to
cc98a94
Compare
andreeleuterio
requested changes
Dec 12, 2024
andreeleuterio
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add size limit enforcement and historical tracking for extension bundles to prevent unexpected size increases. This helps maintain performance and download speeds for users.
Part of the linear issue for Cody Performance
The purpose of this PR is to have bundle sizing measurements for both the extension and the webview. After having them, integrate them into the CI. If you were to add a dependency that increases the bundle size by a lot, it will fail the CI, therefore you have to be cautious about making reckless changes. If you really have to do it, making changes in the CI would force you to make potential changes with extension bloating carefully. NOTE the limit is set to 10% extra so its unlikely you will hit that limit unless you do some really reckless changes.
NOTE: This PR also puts the size of the bundle in bigquery on every release
This PR also tracks the bundle sizes on every pre-release along with the date so we have a record of the time when small changes happened and we can then use the bigquery table to see how the bundle sizes evolved.
Test plan
The failure mode looks like this and you see this failure mode on the build step so when you do a build and it makes very large bundle then the build fails and you have to talk to team cody core to get permission from Grace/dom before making big changes but for small bundle changes this will pass.
Since I couldn't actually run the release github action as that would make the release I decided to make a close approximation in another github action which would entail getting the release version and then making a bigquery request to update a row in the table to mark the date and the sizes of the bundles
This is the workflow file and this is the run.
Changelog